libteam: Adding build.sh script by stcheng · Pull Request #18 · sonic-net/sonic-buildimage

stcheng · 2016-09-29T01:14:51Z

No description provided.

lguohan

please drop 0001-temporary-fix-to-suppress-lacp_set_mac.patch, it's better to patch the driver.

lguohan · 2016-09-29T09:27:39Z

src/libteam/build.sh

why not use tag?

there is no need to clone github libteam. you can use uscan to download the source code.
see here. https://wiki.debian.org/debian/watch

I will prefer to use tag. I notice using uscan does the same job except that I need to do more untar and folder moving jobs before making the deb packages.

lguohan · 2016-09-29T09:34:14Z

build.sh is not enough, please add src/Makefile changes to it together, and also dockerfile in this CR.

qiluo-msft · 2016-09-29T18:01:19Z

dockers/docker-team/start.sh

remove this blank line?

qiluo-msft

Please also check with other reviewers.

lguohan · 2016-09-30T04:18:49Z

dockers/docker-team/Dockerfile

do you need to install the the latest libnl3 in this docker?

lguohan

need to install libnl 3.2.27 in the docker.

stcheng · 2016-09-30T04:47:01Z

updated

lguohan · 2016-09-30T06:14:02Z

src/Makefile

need to add LIBNL-DEBS here, otherwise because building them requires libnl, I believe.

stcheng · 2016-10-07T17:25:50Z

updated

lguohan · 2016-10-07T17:29:39Z

I do not see you install our libnl in the docker-term's dockerfile.

stcheng · 2016-10-07T17:31:40Z

just update that issue

qiluo-msft

Found an old issue.

qiluo-msft · 2016-11-08T19:42:06Z

src/Makefile

 libnl-%.deb:
 	pushd libnl3; ./build.sh; popd

+libteam5_1.26-1_amd64.deb libteam-dev_1.26-1_amd64.deb libteam-utils_1.26-1_amd64.deb libteamdctl0_1.26-1_amd64.deb: libnl-%.deb


Is wildcard in rule source really working? Why not use LIBNL-DEBS?

Including the following commits: Add support for Dell S6100 and Z9100 module deinit (#18) Disable S6100 low power mode by default (#19) Signed-off-by: Shu0T1an ChenG <[email protected]>

…form kernel 4.7 and later. (sonic-net#18) Signed-off-by: roy_lee <[email protected]>

* [quagga]: update quagga submodule 0bc6bd6 2018-05-11 | ignore nexthop attribute when NLRI is present (#18) (HEAD, origin/debian/0.99.24.1, origin/HEAD) [lguohan] Signed-off-by: Guohan Lu <[email protected]> * add vs bgp test Signed-off-by: Guohan Lu <[email protected]>

- Merge pull request sonic-net#18 from yxieca/no_buffering - Revert "Pep 8 compliance, code cleanup (sonic-net#15)" (sonic-net#16) - Pep 8 compliance, code cleanup (sonic-net#15) - add detailed comments for get_transceiver_change_event (sonic-net#12) Signed-off-by: Ying Xie <[email protected]>

- Merge pull request #18 from yxieca/no_buffering - Revert "Pep 8 compliance, code cleanup (#15)" (#16) - Pep 8 compliance, code cleanup (#15) - add detailed comments for get_transceiver_change_event (#12) Signed-off-by: Ying Xie <[email protected]>

This update brings in the following commits. 86c1108 Enable arm architecture to build in addition to amd64 (sonic-net#37) 4acb2c3 fix bugs and enhance Transformer (sonic-net#35) 49e5a22 ygot related enhancements and fixes (sonic-net#34) 51224de Fix ietf yang search path for cvl schema builds (sonic-net#32) 3c6cdb3 CVL Changes sonic-net#8: 'must' and 'when' expression evaluation (sonic-net#31) dabf231 CVL Changes sonic-net#7: 'leafref' evaluation (sonic-net#28) 6f9535f CVL Changes sonic-net#6: Customized Xpath Engine integration (sonic-net#27) 5e2466b DB-Layer fixes/enhancements (sonic-net#26) 9a27302 CVL Changes sonic-net#4: Implementation of new CVL APIs (sonic-net#22) dbf1093 Translib support for authorization, yang versioning and Delete flag (sonic-net#21) 80f369e CVL Changes sonic-net#5: YParser enhancement (sonic-net#23) 904ce18 CVL Changes sonic-net#3: Multi-db instance support (sonic-net#20) 9d24a34 CVL Changes sonic-net#2: YValidator infra changes for evaluating xpath expression (sonic-net#19) f3fc40f CVL Changes sonic-net#1: Initial CVL code reorganization and common infra changes (sonic-net#18) 4922601 Bulk and RPC API support in translib (sonic-net#16) 1d730df RFC7895 yang module library implementation (sonic-net#15)

This update brings in the following commits. 86c1108 Enable arm architecture to build in addition to amd64 (#37) 4acb2c3 fix bugs and enhance Transformer (#35) 49e5a22 ygot related enhancements and fixes (#34) 51224de Fix ietf yang search path for cvl schema builds (#32) 3c6cdb3 CVL Changes #8: 'must' and 'when' expression evaluation (#31) dabf231 CVL Changes #7: 'leafref' evaluation (#28) 6f9535f CVL Changes #6: Customized Xpath Engine integration (#27) 5e2466b DB-Layer fixes/enhancements (#26) 9a27302 CVL Changes #4: Implementation of new CVL APIs (#22) dbf1093 Translib support for authorization, yang versioning and Delete flag (#21) 80f369e CVL Changes #5: YParser enhancement (#23) 904ce18 CVL Changes #3: Multi-db instance support (#20) 9d24a34 CVL Changes #2: YValidator infra changes for evaluating xpath expression (#19) f3fc40f CVL Changes #1: Initial CVL code reorganization and common infra changes (#18) 4922601 Bulk and RPC API support in translib (#16) 1d730df RFC7895 yang module library implementation (#15)

* src/sonic-ztp c959371...dd025bc (2): > Update all references to new 'sonic-installer' file name (sonic-net#18) > Filter out non-printable characters read from syseeprom (sonic-net#17)

Signed-off-by: Andriy Kokhan <[email protected]>

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <[email protected]> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <[email protected]> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <[email protected]> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <[email protected]> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <[email protected]> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <[email protected]> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <[email protected]> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <[email protected]> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <[email protected]> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <[email protected]> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <[email protected]> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <[email protected]> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <[email protected]> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <[email protected]> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <[email protected]> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <[email protected]> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <[email protected]> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <[email protected]> Co-authored-by: KostiantynYarovyiBf <[email protected]> Co-authored-by: Vadym Yashchenko <[email protected]> Co-authored-by: Dmytro Lytvynenko <[email protected]> Co-authored-by: Volodymyr Boiko <[email protected]> Co-authored-by: Petro Bratash <[email protected]> Co-authored-by: Mykola Gerasymenko <[email protected]>

Egress QoS-Map HLD

* Add conf to host, move plugin to sbin * Add missing comma in dependencies * Correct flag to -p * Fix events_info and j2 * Add host event * Revert back to creating and moving * Split into multiple regex for each process * Modify regex and set .py to sbin in monit_events

…nfra changes (sonic-net#18) - Why I did it As part of CVL code update and new features addition, the existing CVL code has to be reorganized and common infra needs to be changed. - How I did it N/A. Please refer to change log for more details. - How to verify it No specific test cases to be executed. Run cvl go test cases using - 'make cvl-test'. - Description for the changelog Modify Makefiles Modify CVL Makefile for cleanall rule Modify Makefile for CVL YIN schema generation Modify Makefile for CVL test YIN schema generation Moved cache, syntax and semantic related code from cvl.go to cvl_cache.go, cvl_syntax.go and cvl_semantics.go respectively . Added new API signatures for integration. Implementation will be added in subsequent PRs. Copied sonic-port.yang and sonic-acl.yang to CVL own's test folder.

* Update to Linux 6.1.94 Signed-off-by: Saikrishna Arcot <[email protected]> * Integrate HW-MGMT 7.0040.1008 Changes (#18) * Integrate HW-MGMT 7.0040.1011 Changes (#19) * Update sonic-linux-kernel submodule (#20) Signed-off-by: Vivek Reddy <[email protected]> --------- Signed-off-by: Saikrishna Arcot <[email protected]> Signed-off-by: Vivek Reddy <[email protected]> Co-authored-by: Vivek <[email protected]>

…tically (sonic-net#682) #### Why I did it src/sonic-sairedis ``` * 2e00768 - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-sairedis:202411 to 202412 (sonic-net#18) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog

…omatically (sonic-net#705) #### Why I did it src/sonic-swss-common ``` * 0d42e0a - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request sonic-net#19 from r12f/code-sync-202412 (18 hours ago) [Riff] |\ | failure_prs.log skip_prs.log 3fa36f4 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (19 hours ago) [r12f] |/| | failure_prs.log skip_prs.log 7aa1a47 - Added field for policer counter (sonic-net#975) (7 days ago) [mssonicbld] | failure_prs.log skip_prs.log 8f47a37 - Handle 'bulkget' in consumer_table_pops.lua (sonic-net#970) (3 weeks ago) [mssonicbld] * 3f09bf0 - [code sync] Merge code from sonic-net/sonic-swss-common:202411 to 202412 (sonic-net#18) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (sonic-net#704) #### Why I did it src/sonic-linux-kernel ``` * 6877ae3 - (HEAD -> 202412, origin/HEAD, origin/202412) [optoe] Reset page select byte to 0 before upper memory access on page 0h (sonic-net#464) (sonic-net#18) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog

…ly (#22549) #### Why I did it src/sonic-bmp ``` * d880861 - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #18 from sonic-net/fixlog (3 hours ago) [Feng-msft] * 014d101 - (origin/fixlog) Adjust disable logging into debug level to avoid log spawn (18 hours ago) [Feng Pan] ``` #### How I did it #### How to verify it #### Description for the changelog

… 202412 (#18) ```<br>* d0aed43 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-02-13) [Sonic Automation] * c735073 - (origin/202411) [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin] * b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```

…UT so that we can get back to back Paladin ports up with Arista-7060X6-16PE-384C-O128S2 (sonic-net#1144)  #### Why I did it Currently when we loaded HWSKU `Arista-7060X6-16PE-384C-O128S2` on two moby devices and connect their Paladin ports back to back, we can't get link up. It may help if we can get these links up and run the tests. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Created a new `FANOUT` HWSKU containing special lanemap and polarity configs so that we can load `Arista-7060X6-16PE-384C-O128S2` on one Moby and `Arista-7060X6-16PE-384C-O128S2-FANOUT` and get Paladin ports up when connecting them back to back with the following setup: ``` Moby1 Moby2 HWSKU: Arista-7060X6-16PE-384C-O128S2 HWSKU: Arista-7060X6-16PE-384C-O128S2-FANOUT sonic-net#17 <-> sonic-net#18 sonic-net#19 <-> sonic-net#20 sonic-net#21 <-> sonic-net#22 sonic-net#23 <-> sonic-net#24 sonic-net#18 <-> sonic-net#17 sonic-net#20 <-> sonic-net#19 sonic-net#22 <-> sonic-net#21 sonic-net#24 <-> sonic-net#23 ``` #### How to verify it Verified that all the Paladin ports can link up with the above setup.  #### Which release branch to backport (provide reason below if selected)  - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] msft-202412 #### Tested branch (Please provide the tested image version)  - [ ]  - [ ]  - [x] msft-202412 #### Description for the changelog  Created `Arista-7060X6-16PE-384C-O128S2-FANOUT` based on `Arista-7060X6-16PE-384C-O128S2` and only update lanemap and polarity settings in bcm config.  #### Link to config_db schema for YANG module changes  #### A picture of a cute animal (not mandatory but encouraged)

…t back to back Paladin ports up with Arista-7060X6-16PE-384C-O128S2  #### Why I did it Currently when we loaded HWSKU `Arista-7060X6-16PE-384C-O128S2` on two moby devices and connect their Paladin ports back to back, we can't get link up. It may help if we can get these links up and run the tests. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Created a new `FANOUT` HWSKU containing special lanemap and polarity configs so that we can load `Arista-7060X6-16PE-384C-O128S2` on one Moby and `Arista-7060X6-16PE-384C-O128S2-FANOUT` and get Paladin ports up when connecting them back to back with the following setup: ``` Moby1 Moby2 HWSKU: Arista-7060X6-16PE-384C-O128S2 HWSKU: Arista-7060X6-16PE-384C-O128S2-FANOUT sonic-net#17 <-> sonic-net#18 sonic-net#19 <-> sonic-net#20 sonic-net#21 <-> sonic-net#22 sonic-net#23 <-> sonic-net#24 sonic-net#18 <-> sonic-net#17 sonic-net#20 <-> sonic-net#19 sonic-net#22 <-> sonic-net#21 sonic-net#24 <-> sonic-net#23 ``` #### How to verify it Verified that all the Paladin ports can link up with the above setup.  #### Which release branch to backport (provide reason below if selected)  - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] msft-202412 #### Tested branch (Please provide the tested image version)  - [ ]  - [ ]  - [x] msft-202412 #### Description for the changelog  Created `Arista-7060X6-16PE-384C-O128S2-FANOUT` based on `Arista-7060X6-16PE-384C-O128S2` and only update lanemap and polarity settings in bcm config.  #### Link to config_db schema for YANG module changes  #### A picture of a cute animal (not mandatory but encouraged)

…t back to back Paladin ports up with Arista-7060X6-16PE-384C-O128S2 (#22719)  #### Why I did it Currently when we loaded HWSKU `Arista-7060X6-16PE-384C-O128S2` on two moby devices and connect their Paladin ports back to back, we can't get link up. It may help if we can get these links up and run the tests. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Created a new `FANOUT` HWSKU containing special lanemap and polarity configs so that we can load `Arista-7060X6-16PE-384C-O128S2` on one Moby and `Arista-7060X6-16PE-384C-O128S2-FANOUT` and get Paladin ports up when connecting them back to back with the following setup: ``` Moby1 Moby2 HWSKU: Arista-7060X6-16PE-384C-O128S2 HWSKU: Arista-7060X6-16PE-384C-O128S2-FANOUT #17 <-> #18 #19 <-> #20 #21 <-> #22 #23 <-> #24 #18 <-> #17 #20 <-> #19 #22 <-> #21 #24 <-> #23 ``` #### How to verify it Verified that all the Paladin ports can link up with the above setup.  #### Which release branch to backport (provide reason below if selected)  - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] msft-202412 #### Tested branch (Please provide the tested image version)  - [ ]  - [ ]  - [x] msft-202412 #### Description for the changelog  Created `Arista-7060X6-16PE-384C-O128S2-FANOUT` based on `Arista-7060X6-16PE-384C-O128S2` and only update lanemap and polarity settings in bcm config.  #### Link to config_db schema for YANG module changes  #### A picture of a cute animal (not mandatory but encouraged)

…tomatically (sonic-net#1498) #### Why I did it src/sonic-gnmi ``` * 3679372 - (HEAD -> 202412, origin/202412) Add SHOW implementation for interface transceiver error-status. (sonic-net#18) (4 hours ago) [mssonicbld] * 45d679a - Add show watermark telemetry interval implementation (sonic-net#16) (19 hours ago) [mssonicbld] * 57d0b6f - Simplify option support for all SHOW paths (sonic-net#15) (23 hours ago) [mssonicbld] * 7dd2615 - Add support for show int error (sonic-net#14) (24 hours ago) [mssonicbld] * d8e0216 - Add SHOW implementation for interface counters (#11) (25 hours ago) [mssonicbld] * 6c56f41 - [202412] Manual cherrypick for adding support for RATES tables in Counters DB so that PRE_FEC/POST_FEC_BER via ST (#13) (26 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog

…test HEAD automatically (sonic-net#1190) #### Why I did it src/sonic-platform-daemons ``` * b2ea037 - (HEAD -> 202503, origin/202503) Merge pull request sonic-net#18 from mssonicbld/cherry/msft-202503/565 (2 hours ago) [Arvindsrinivasan Lakshmi Narasimhan] * 2a57090 - Take non-CMIS xcvrs out of lpmode in SFF Manager (20 hours ago) [Sonic Build Admin] ``` #### How I did it #### How to verify it #### Description for the changelog

stcheng self-assigned this Sep 29, 2016

lguohan requested changes Sep 29, 2016

View reviewed changes

qiluo-msft requested changes Sep 29, 2016

View reviewed changes

qiluo-msft approved these changes Sep 29, 2016

View reviewed changes

lguohan approved these changes Sep 30, 2016

View reviewed changes

lguohan reviewed Sep 30, 2016

View reviewed changes

lguohan requested changes Sep 30, 2016

View reviewed changes

libteam: Adding build.sh script and docker-team

c4c7a18

lguohan approved these changes Oct 7, 2016

View reviewed changes

stcheng merged commit 4373c51 into sonic-net:master Oct 7, 2016

stcheng deleted the libteam branch October 7, 2016 17:43

qiluo-msft reviewed Nov 8, 2016

View reviewed changes

stcheng mentioned this pull request Oct 13, 2017

[Dell]: Update sonic-platform-modules-dell submodule #1041

Merged

Staphylo pushed a commit to Staphylo/sonic-buildimage that referenced this pull request Mar 6, 2018

[platform] as5712-54x: update i2c-mux-accton_as5712_54x_cpld.c to con…

00f6efe

…form kernel 4.7 and later. (sonic-net#18) Signed-off-by: roy_lee <[email protected]>

lguohan mentioned this pull request May 11, 2018

[quagga]: update quagga submodule #1698

Merged

tylerlinp mentioned this pull request Aug 28, 2018

[crmorch] orchagent crash when destructing crmorch #1991

Closed

yxieca mentioned this pull request Dec 4, 2018

[platform-common] advance sonic-platform-common submodule head #2339

Merged

carl-nokia mentioned this pull request Nov 19, 2020

[sonic-mgmt-common] Update submodule #5961

Closed

3 tasks

dflynn-Nokia mentioned this pull request Dec 4, 2020

[sonic-mgmt-common] Update submodule #6129

Merged

3 tasks

xumia referenced this pull request in xumia/sonic-buildimage-1 Feb 16, 2021

Update README.md (#18)

5d57aeb

SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Jun 16, 2021

Remove prefix "oid:0x" from sai oid (sonic-net#18)

3b07479

mikeberesford mentioned this pull request Jul 14, 2021

occasional syncd crash at initialization time #8177

Closed

KostiantynYarovyiBf pushed a commit to KostiantynYarovyiBf/sonic-buildimage that referenced this pull request Dec 14, 2021

Added PSU temperature skip into platform.json (sonic-net#18)

a86c7be

Signed-off-by: Andriy Kokhan <[email protected]>

VadymYashchenko referenced this pull request in VadymYashchenko/sonic_buildimage Dec 20, 2021

Added PSU temperature skip into platform.json (#18)

31332ad

Signed-off-by: Andriy Kokhan <[email protected]>

VadymYashchenko referenced this pull request in VadymYashchenko/sonic_buildimage Dec 24, 2021

Added PSU temperature skip into platform.json (#18)

110f8ab

Signed-off-by: Andriy Kokhan <[email protected]>

SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Mar 16, 2022

[bug fix]: handle the case when alias_map is empty (sonic-net#18)

c1b2201

sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022

Merge pull request sonic-net#18 from jainp1979/master

966e5bd

Egress QoS-Map HLD

shanshri pushed a commit to shanshri/sonic-buildimage-sonic-net that referenced this pull request Oct 24, 2023

download original files from azure storage (sonic-net#18)

73e99e9

Purnimayeggina mentioned this pull request Feb 13, 2024

Issue with NTP Server Synchronization - Clock Unsynchronized #18085

Open

Conversation

stcheng commented Sep 29, 2016

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan commented Sep 29, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

stcheng commented Sep 30, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stcheng commented Oct 7, 2016

Uh oh!

lguohan commented Oct 7, 2016

Uh oh!

stcheng commented Oct 7, 2016

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Nov 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qiluo-msft Nov 8, 2016 •

edited

Loading